Fix for rt70740 #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding new values to a query, they would appear in reverse order when adding from scratch, but in the specified order when adding to an existing key. This change makes the order items are added to the query consistent. It also brings the interface of query_param_append in line with that of query_param, supporting array refs as well as simple lists. Updated tests to check for the new behaviour and use Test::More, which was in core at the minimum perl version specified in the Makefile.PL
|
Thanks. This was applied as 63e7730 and released in URI-1.60. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding new values to a query, they would appear in reverse order
when adding from scratch, but in the specified order when adding to an
existing key.
This change makes the order items are added to the query consistent.
It also brings the interface of query_param_append in line with that of
query_param, supporting array refs as well as simple lists.
Updated tests to check for the new behaviour and use Test::More, which
was in core at the minimum perl version specified in the Makefile.PL